Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Updated esprima-dotnet reference #664

Merged
merged 2 commits into from Sep 23, 2019
Merged

Updated esprima-dotnet reference #664

merged 2 commits into from Sep 23, 2019

Conversation

ahmetkakici
Copy link
Contributor

Jint had reference to esprima 1.0.0-beta-1186 which was causing IndexOutOfRangeException exception while parsing invalid code:
new JavaScriptParser("....").ParseProgram();

After updating reference to 1.0.0-beta-1202, it now throws ParserException which is expected.
I've also added tests for this case.

System.IndexOutOfRangeException: Index was outside the bounds of the array.
at Esprima.Scanner.ScanPunctuator() in C:\projects\esprima-dotnet\src\Esprima\Scanner.cs:line 696
at Esprima.Scanner.Lex() in C:\projects\esprima-dotnet\src\Esprima\Scanner.cs:line 1699
at Esprima.JavaScriptParser.NextToken() in C:\projects\esprima-dotnet\src\Esprima\JavascriptParser.cs:line 259
at Esprima.JavaScriptParser.ParsePrimaryExpression() in C:\projects\esprima-dotnet\src\Esprima\JavascriptParser.cs:line 618
at Esprima.JavaScriptParser.InheritCoverGrammar[T](Func1 parseFunction) in C:\projects\esprima-dotnet\src\Esprima\JavascriptParser.cs:line 497 at Esprima.JavaScriptParser.ParseLeftHandSideExpressionAllowCall() in C:\projects\esprima-dotnet\src\Esprima\JavascriptParser.cs:line 1351 at Esprima.JavaScriptParser.InheritCoverGrammar[T](Func1 parseFunction) in C:\projects\esprima-dotnet\src\Esprima\JavascriptParser.cs:line 497
at Esprima.JavaScriptParser.ParseUpdateExpression() in C:\projects\esprima-dotnet\src\Esprima\JavascriptParser.cs:line 1486
at Esprima.JavaScriptParser.ParseUnaryExpression() in C:\projects\esprima-dotnet\src\Esprima\JavascriptParser.cs:line 1535
at Esprima.JavaScriptParser.InheritCoverGrammar[T](Func1 parseFunction) in C:\projects\esprima-dotnet\src\Esprima\JavascriptParser.cs:line 497 at Esprima.JavaScriptParser.ParseExponentiationExpression() in C:\projects\esprima-dotnet\src\Esprima\JavascriptParser.cs:line 1545 at Esprima.JavaScriptParser.InheritCoverGrammar[T](Func1 parseFunction) in C:\projects\esprima-dotnet\src\Esprima\JavascriptParser.cs:line 497
at Esprima.JavaScriptParser.ParseBinaryExpression() in C:\projects\esprima-dotnet\src\Esprima\JavascriptParser.cs:line 1655
at Esprima.JavaScriptParser.InheritCoverGrammar[T](Func1 parseFunction) in C:\projects\esprima-dotnet\src\Esprima\JavascriptParser.cs:line 497 at Esprima.JavaScriptParser.ParseConditionalExpression() in C:\projects\esprima-dotnet\src\Esprima\JavascriptParser.cs:line 1722 at Esprima.JavaScriptParser.ParseAssignmentExpression() in C:\projects\esprima-dotnet\src\Esprima\JavascriptParser.cs:line 1862 at Esprima.JavaScriptParser.IsolateCoverGrammar[T](Func1 parseFunction) in C:\projects\esprima-dotnet\src\Esprima\JavascriptParser.cs:line 474
at Esprima.JavaScriptParser.ParseExpression() in C:\projects\esprima-dotnet\src\Esprima\JavascriptParser.cs:line 1955
at Esprima.JavaScriptParser.ParseExpressionStatement() in C:\projects\esprima-dotnet\src\Esprima\JavascriptParser.cs:line 2415
at Esprima.JavaScriptParser.ParseStatement() in C:\projects\esprima-dotnet\src\Esprima\JavascriptParser.cs:line 3011
at Esprima.JavaScriptParser.ParseStatementListItem() in C:\projects\esprima-dotnet\src\Esprima\JavascriptParser.cs:line 2025
at Esprima.JavaScriptParser.ParseProgram(Boolean strict) in C:\projects\esprima-dotnet\src\Esprima\JavascriptParser.cs:line 162

@lahma lahma merged commit 14033f2 into sebastienros:dev Sep 23, 2019
@lahma
Copy link
Collaborator

lahma commented Sep 23, 2019

Thank you!

ruixiao-yu pushed a commit to cyclr/jint that referenced this pull request Feb 13, 2020
* Updated Esprima package from 1.0.0-beta-1186 to 1.0.0-beta-1202
* Added test for handling parser exception of javascript parser.
ruixiao-yu added a commit to cyclr/jint that referenced this pull request Feb 19, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants