Fix StringDictionarySlim enumeration after first item delete #677
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
I imagine the pain to find the issue |
|
Just some hours of good old head-scratching and trying to find correct debug points to get before and after effects, didn't enjoy this one a bit 😄 |
sebastienros
approved these changes
Oct 24, 2019
ruixiao-yu
pushed a commit
to cyclr/jint
that referenced
this pull request
Feb 13, 2020
ruixiao-yu
added a commit
to cyclr/jint
that referenced
this pull request
Feb 19, 2020
…ebastienros#677)" This reverts commit dbbafb1.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This was fun to track down. StringDictionarySlim's enumerator was returning deleted items when item that was deleted had first bucket index. This was actually fixed in CoreFX Labs version some time ago, we just didn't have the fix incorporated.
Fixes #670