New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix string indexing detecting string starting with $ as NaN and thus 0 #699

Merged

lahma merged 1 commit into sebastienros:dev from lahma:bugs/fix-string-indexing-checks

Jan 14, 2020

Collaborator

lahma commented Jan 13, 2020

fixes #698


          fix string indexing detecting $ as NaN and thus 0

02b8f12

lahma mentioned this pull request

Issue with property names prefixed with $ #698

Closed

sebastienros approved these changes

View reviewed changes

lahma merged commit 4544bdb into sebastienros:dev

lahma deleted the bugs/fix-string-indexing-checks branch

January 14, 2020 05:36

Collaborator Author

lahma commented Jan 14, 2020

This actually gave me an idea for optimizing some basic indexing 😅

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment