Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add current memory usage to debug information #705

Merged
merged 2 commits into from Feb 18, 2020
Merged

Add current memory usage to debug information #705

merged 2 commits into from Feb 18, 2020

Conversation

ceifa
Copy link
Contributor

@ceifa ceifa commented Feb 18, 2020

No description provided.

@sebastienros
Copy link
Owner

Looks good, but build fails

@sebastienros sebastienros merged commit f2a9230 into sebastienros:dev Feb 18, 2020
@ceifa
Copy link
Contributor Author

ceifa commented Feb 27, 2020

Thank you for merging! Do you have a prevision to publish this version in nuget?

@sebastienros
Copy link
Owner

Build is running, should be ready in an hour if all goes well.

@sebastienros
Copy link
Owner

Follow this: https://ci.appveyor.com/project/SebastienRos/jint/builds/31109993

@ceifa
Copy link
Contributor Author

ceifa commented Feb 28, 2020

I'm receiving this error now:
image

If i put the myget source of esprima it works, but can you create a nuget release for it too?

@sebastienros
Copy link
Owner

snap :/ we must have a wrong version in the config

@sebastienros
Copy link
Owner

Fixed

@ceifa
Copy link
Contributor Author

ceifa commented Mar 3, 2020

After I started using this feature, I realized the value isn't the memory usage, but the memory allocated in the lifetime, since it's not subtracted when the memory is released.

The property and some internal fields should be renamed or reimplemented to comply with the name and what the value is.

I will make a PR to fix it sometime, I'm just commenting to make sure you know it or have something against it.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants