Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix possible NRE in CallStackElement construction #708

Merged
merged 4 commits into from Mar 4, 2020
Merged

Fix possible NRE in CallStackElement construction #708

merged 4 commits into from Mar 4, 2020

Conversation

lahma
Copy link
Collaborator

@lahma lahma commented Mar 4, 2020 •
edited

fixes #707

@lahma lahma added the bug label Mar 4, 2020
@ashepetko
Copy link

Could you please add the fix for the very similar problem to the following line:

jint/Jint/Runtime/ExceptionHelper.cs

Line 40 in 6e92af9

ThrowReferenceError(engine, (reference?.GetReferencedName()).ToString());

@ashepetko ashepetko mentioned this pull request Mar 4, 2020
Closed
@lahma
Copy link
Collaborator Author

lahma commented Mar 4, 2020

@ashepetko thanks for pointing this out, I've added a tweak to ExceptionHelper too.

@sebastienros
Copy link
Owner

Pending failed tests

@lahma
Copy link
Collaborator Author

lahma commented Mar 4, 2020

Darn, pushed an intermediate version which I used ensure test case is red... Pushed a fix.

@sebastienros sebastienros merged commit e43290d into sebastienros:dev Mar 4, 2020
@lahma lahma deleted the bugs/fix-nre branch March 4, 2020 18:46
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@sebastienros sebastienros sebastienros approved these changes

Assignees
No one assigned
Labels
bug
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

NullReferenceException in IIFE when limiting recursion
3 participants
@lahma @ashepetko @sebastienros