Don't throw when CLR indexer not found #718
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
lahma
approved these changes
Apr 4, 2020
lahma
reviewed
Apr 4, 2020
Jint/Runtime/TypeConverter.cs
Outdated
| @@ -490,6 +490,8 @@ private static string ToStringNonString(JsValue o) | |||
| return Null.Text; | |||
| case InternalTypes.Object when o is IPrimitiveInstance p: | |||
| return ToString(ToPrimitive(p.PrimitiveValue, Types.String)); | |||
| case InternalTypes.Object when o is Interop.IObjectWrapper p: | |||
| return ToString(ToPrimitive(p.Target?.ToString(), Types.String)); | |||
There was a problem hiding this comment.
I'm not sure if the ToPrimitive is needed here as we know that ToString produces string? Basically could just be p.Target?.ToString()?
There was a problem hiding this comment.
Thanks, didn't if it would do something special, changing
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #500