Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Propagate interop exceptions from IndexDescriptor #728

Merged

Conversation

lahma
Copy link
Collaborator

@lahma lahma commented Apr 22, 2020

We should let inner exception of TargetInvocationException to flow through. Still we can check ArgumentOutOfRangeException to ensure undefined is returned from invalid indexing, like our beloved JS does.

fixes #652

@sebastienros sebastienros merged commit 0f2c39b into sebastienros:dev May 26, 2020
@lahma lahma deleted the bugs/propagate-indexer-exceptions branch November 4, 2020 08:07
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Exceptions in indexers are swallowed
2 participants