EnsureCapacity can throw if called against sparse mode array #746
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
sebastienros
approved these changes
Jun 8, 2020
| { | ||
| const string code = @" | ||
| let arr = []; | ||
| for (let i = 0; i < 10000; i++) arr.push(i); |
There was a problem hiding this comment.
Showing off with these let keywords now ;)
| @@ -648,13 +648,15 @@ private void ConvertToSparse() | |||
|
|
|||
| internal void EnsureCapacity(uint capacity) | |||
| { | |||
| if (capacity <= MaxDenseArrayLength && capacity > (uint) _dense.Length) | |||
| if (capacity > MaxDenseArrayLength || _dense is null || capacity <= (uint) _dense.Length) | |||
There was a problem hiding this comment.
I understand that the capacity doubles?
There was a problem hiding this comment.
Capacity is decided by the caller, we can grow as asked if it hasn't flipped to be dictionary (sparse) already. Usually logic asks for double the size but for example splice knows what to expect and thus was signaling specific size when algorithm is at specific point. Same like using constructor parameter, can signal known size.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
fixes #745