Add protected function instance constructor

[viceice]

• add protected constructor to FunctionInstance
• add custom uuid type as test

closes: #753

[lahma]

Awesome! This is just the coverage we need more to make sure CLR interop story works for people extending Jint.

[sebastienros]

What do you think about adding an extension method on Options named AddUuid() which would register the converter and also call CreateUuidConstructor ?

[viceice]

Sounds good. Would need some API refactoring.

[lahma]

Can we get away with AddObjectConverter<T>? not sure if we can bind the constructor with that though.

[sebastienros]

@viceice I think we would need a way to add Action to a list that would be executed by the engine when it has initialized the options object.

[viceice]

What about to add Engine.ObjectConverters as public List<IObjectConverter> ObjectConverters => Options._ObjectConverters? so we can add IObjectConverter after Engine contructor finished?

Then the AddUuid() extension would be very easy.

[sebastienros]

I prefer not to since we are looking at ways to reuse engines. Having all the configuration kept in options would allow us to reuse it on any engine instance once cleared of any state. We could even add a list of scripts. Or use these options in a factory object for pooling.

Instead of calling these methods from Engine, we can also have a method Apply(engine) such that the engine code would not change every time we add options. And a Options.Configure (Action) to register custom logic. I can add this to your PR if you prefer.

[viceice]

Ok, feel free to change the PR. 🙃

[viceice]

Maybe I need to give you write access to my fork, because it's in an org.

[sebastienros]

If you haven't unallowed me, then by default I can write on the branch you used to submit a PR

[sebastienros]

Had not realized that all these UUid classes were only in Tests, until I start adding what I suggested.
Doing it in a different PR then.
You should write a wiki entry with this UUid example and how to get to it, would be very helpful for many.

[viceice]

Had not realized that all these UUid classes were only in Tests, until I start adding what I suggested.
Doing it in a different PR then.
You should write a wiki entry with this UUid example and how to get to it, would be very helpful for many.

I've started here.