Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Use a more specific exception in the CancellationConstraint class #769

Merged
merged 1 commit into from Aug 24, 2020
Merged

Use a more specific exception in the CancellationConstraint class #769

merged 1 commit into from Aug 24, 2020

Conversation

Taritsyn
Copy link
Contributor

@Taritsyn Taritsyn commented Aug 3, 2020

Currently the CancellationConstraint is throwing an exception of type StatementsCountOverflowException (same as in the MaxStatements constraint). This implementation makes it more difficult to error handling and find their causes.

In this PR, I replaced a exception of type StatementsCountOverflowException by an exception of type ExecutionCanceledException.

lahma
lahma approved these changes Aug 4, 2020
View reviewed changes
Copy link
Collaborator

@lahma lahma left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Makes sense and looks good with test coverage.

@sebastienros sebastienros merged commit 6da41ae into sebastienros:dev Aug 24, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@lahma lahma lahma approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@Taritsyn @lahma @sebastienros