Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Improve error handling for JToken property access #796

Merged
merged 1 commit into from Nov 4, 2020

Conversation

lahma
Copy link
Collaborator

@lahma lahma commented Nov 4, 2020

  • we can always ignore Symbol properties for CLR objects, they don't exist
  • InvalidOperationException is something like the ArgumentOutOfRangeException and IndexOutOfRangeException which we already ignore

fixes #795

@sebastienros sebastienros merged commit b717934 into sebastienros:dev Nov 4, 2020
@Oceania2018
Copy link

I'm getting error Accessed JArray values with invalid key value: "0". Int32 array index expected when trying to access property of JObject.

Hope we can get it fixed soon.

@Oceania2018
Copy link

After took deeper look at the source. I get some clue and made an ugly fix for my situation.

image

@lahma lahma deleted the jobject-property-access branch November 6, 2020 08:18
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Cannot access child value on Newtonsoft.Json.Linq.JValue in OrchardCore
3 participants