Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix indexing JArray / faster IList indexing #798

Merged
merged 3 commits into from Nov 6, 2020
Merged

Fix indexing JArray / faster IList indexing #798

merged 3 commits into from Nov 6, 2020

Conversation

lahma
Copy link
Collaborator

@lahma lahma commented Nov 6, 2020

  • protect ClrTypeConverter from changing during engine lifetime, should set via options
  • make specialized property handlers internal, they're already sealed so let's not expose too much
  • improve TryFindIndexer to account directly for IList and short-circuit there for indexer when parameter is convertible to number
  • improve performance by detecting integer array indexer access

fixes #797

@lahma lahma marked this pull request as ready for review November 6, 2020 18:13
@lahma lahma merged commit db2fc72 into sebastienros:dev Nov 6, 2020
@lahma lahma deleted the indexing-jarray branch November 6, 2020 18:15
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@sebastienros sebastienros sebastienros approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Access JObject in index failed
2 participants
@lahma @sebastienros