Prioritize Non-Generic methods #815
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
lahma
approved these changes
Dec 9, 2020
| @@ -60,6 +60,17 @@ private static MethodDescriptor[] Prioritize(MethodDescriptor[] descriptors) | |||
| { | |||
| static int CreateComparison(MethodDescriptor d1, MethodDescriptor d2) | |||
| { | |||
| // if its a generic method, put it on the end | |||
| if (d1.Method.IsGenericMethod) | |||
There was a problem hiding this comment.
This is not stable and could potentially create infinite loops with some sort algorithm. The idea being that (a, b) might then be compared again with (b, a) and both would return opposite values if a == b.
If think the test should be that if d1 is generic and not d2, then put it at the end.
windischb
commented
Dec 11, 2020
Comment on lines
74
to
76
| // put params versions to end, they can be tricky to match and can cause trouble / extra overhead | ||
| if (d1.HasParams) | ||
| { |
There was a problem hiding this comment.
Isn't then there the same problem with potentially infinite loops?
There was a problem hiding this comment.
Probably. This is an issue I found while working on Array.Sort this week. Can you fix it too ?
There was a problem hiding this comment.
off course, i just wanted to ask before
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
As mentioned in #814 Generic Methods will now be last in order.
Prevents invoking the Generic Method instead of the Non-Generic Method of same name, if the Generic Method is declared before.
fixes #814