Class support #816
Class support #816
Conversation
| if (name.StartsWith("language/statements/class/subclass/builtin-objects/Promise")) | ||
| { | ||
| skip = true; | ||
| reason = "Promise not implemented"; |
There was a problem hiding this comment.
Just a small PR and you can enable this... Just need to have the constructor logic use correct methods, like I mentioned 😉
| var r = new RegExpInstance(Engine); | ||
| r._prototype = PrototypeObject; | ||
|
|
||
| var scanner = new Scanner(regExp, new ParserOptions { AdaptRegexp = true }); |
There was a problem hiding this comment.
It was never used, so removed dead code with extreme prejudice.
| @@ -14,6 +15,7 @@ public static T ThrowSyntaxError<T>(Engine engine, string message = null) | |||
| return default; | |||
| } | |||
|
|
|||
| [DoesNotReturn] | |||
There was a problem hiding this comment.
Saw that in your other PR, perf only? JIT?
There was a problem hiding this comment.
Basically it helps the compiler. Can write code like:
string? thisCanBeNull = SomeMethod();
if (thisCanBeNull is null)
ThrowHelper.Throw();
// compiler won't complain about possibly being null as it knows the earlier branch won't return this code
thisCanBeNull.Substring(1,2);| var f = new BindFunctionInstance(Engine) | ||
| { | ||
| TargetFunction = thisObj, | ||
| BoundThis = thisObj is ArrowFunctionInstance ? Undefined : thisArg, |
There was a problem hiding this comment.
So no more ArrowFunctionInstance, less code repetition then?
There was a problem hiding this comment.
Yes, they now follow the same logic. We can separate again later if we want to fine-tune, but spec doesn't really talk about it being a separate concept, just configured differently.
| if (expression is CallExpression callExpression) | ||
| { | ||
| expression = callExpression.Callee; | ||
| continue; |
There was a problem hiding this comment.
The while(true) is only for this case? not a recursion instead?
There was a problem hiding this comment.
This is honestly a hack. The correct way to handle this later is to have parser enable options.Range = true which should give us start and end index, then if we have the script (string instance), we can substring it. Might even make sense to always provide those out of Esprima without config switch if there's no real performance penalty. So this is something like best-effort, should be replaced with proper solution...
No description provided.