Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support converting js function into any delegate. #864

Merged
merged 1 commit into from Apr 19, 2021

Conversation

Dogwei
Copy link
Contributor

@Dogwei Dogwei commented Apr 10, 2021

1.Compared with the previous scheme, more delegate types are now supported.
2.Shorter implementation.
3.There are still some unforeseen errors unhandled, such as ChangeType may not supported, or ref struct type.

Copy link
Collaborator

@lahma lahma left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code did indeed get a lot cleaner and old test cases still work. We'll see if there are any problems with some cases we don't currently cover. Thank you!

@lahma lahma merged commit 10e453b into sebastienros:dev Apr 19, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants