Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add support for Optional Chaining #881

Merged
merged 3 commits into from May 18, 2021
Merged

Conversation

lahma
Copy link
Collaborator

@lahma lahma commented May 4, 2021

  • align some code more closer to spec like eval and records
  • reuse identifier/member resolution and function calls and add support for optional chain, we already have this optimized a bit different than in spec
  • added test cases from 262 suite

fixes #863

@lahma lahma force-pushed the optional-chaining branch 2 times, most recently from debecb8 to c528d79 Compare May 10, 2021 17:47
@@ -57,18 +57,22 @@ private static void Main(string[] args)
Console.ForegroundColor = defaultColor;
Console.Write("jint> ");
var input = Console.ReadLine();
if (input == "exit")
if (input is "exit" or ".exit")
Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I made the command line a bit more node like, wanted to also see statement execution results like in node console

@lahma lahma marked this pull request as ready for review May 18, 2021 05:04
@lahma lahma requested a review from sebastienros May 18, 2021 05:09
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Any plans to implement ECMA 2020 Optional Chaining?
2 participants