Run engine tests #892
Run engine tests #892
Conversation
|
Windows, Linux and MacOS will make a lovely combo 👌🏻 |
|
Focusing on Linux only for now, will add the matrix when it works. Though not sure it should run everything, will depend on the time it takes. Or maybe just for the Publish step. |
|
Some build logic probably helps, maybe in c# 🤔 |
|
Everything seems to work, even the publish task using the tags (from any branch). I just used a fake API key to test. |
| @@ -1,6 +1,7 @@ | |||
| <Project Sdk="Microsoft.NET.Sdk"> | |||
| <PropertyGroup> | |||
| <TargetFrameworks>net461;net5.0</TargetFrameworks> | |||
| <TargetFrameworks>net5.0</TargetFrameworks> | |||
There was a problem hiding this comment.
would be nice to have windows included and also net461 tested
There was a problem hiding this comment.
Looking good. Would be nice to have the build matrix setup for windows and macos too. I guess with this we won't easily get the release notes generation based on commits and contributors document generation, but maybe just basic yaml then instead of new era build automation 😛
|
Added windows builds, running met461 only on it since 5.0 is tested on linux. That keeps the PR builds under 5 minutes. |
|
Re-added net5.0 on windows |
No description provided.