Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Introduce Engine.Evaluate #899

Merged
merged 2 commits into from May 18, 2021
Merged

Introduce Engine.Evaluate #899

merged 2 commits into from May 18, 2021

Conversation

lahma
Copy link
Collaborator

@lahma lahma commented May 18, 2021 •
edited

Code gets more succinct as chaining is no longer needed to get result. Keeping the GetCompletionValue with Obsolete attribute, maybe someone will yell.

@lahma lahma marked this pull request as ready for review May 18, 2021 18:04
sebastienros
sebastienros approved these changes May 18, 2021
View reviewed changes
Copy link
Owner

@sebastienros sebastienros left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Needs update on readme

@lahma
Copy link
Collaborator Author

lahma commented May 18, 2021 •
edited

Removed references to Execute in favor of Evaluate

@lahma lahma merged commit e6f54b5 into sebastienros:main May 18, 2021
@lahma lahma deleted the evaluate branch May 18, 2021 18:19
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@sebastienros sebastienros sebastienros approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@lahma @sebastienros