Fix Array.from, entries, spread and other iterator related methods #927
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary of fixes:
Symbol.iterator
to iterator objectstrimLeft
andtrimRight
. They are the same astrimStart
andtrimEnd
according to MDNArray.from
,entries
, spread syntaxExtractValueFromIteratorInstance
method. It was causing trouble for nested arrays. I think it was added mistakenly because of the bug inentries
I was surprised that no tests fail because of
entries
change. Maybe there was no test coverage for that?