New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix eval and function constructor failing for object literals with __proto__ prop #948
Conversation
I quickly checked just one test case and its contents: function testcase()
{
try
{
eval('"use strict"; var x = "\\17";');
return false;
}
catch (e) {
return (e instanceof SyntaxError);
}
}
runTestCase(testcase); So my hunch is that it's a strict mode issue. At least |
I think this should be solved in Esprima.NET. Basically, this should work: This should fail: I will try to fix it. |
Created sebastienros/esprima-dotnet#192 There is no need to change any code in Jint. Only tests. But I noticed that by making |
Main branch has been updated with latest Esprima. Is there still an issue that we need to fix? |
Let me test real quick. |
Good to go. It is only tests. |
Thanks for verifying! |
Related to #598
Fixes weren't applied to Eval and Function Ctor before.
Edit after tests:
Tolerant = true
breaks other tests. Do you know what may be a better solution?