Implement Object.hasOwn #960
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
I guess test262 repo already has test cases? They usually are the truth. https://github.com/tc39/test262/tree/main/test/built-ins/Object/hasOwn So basically copying them to correct place in test262 project's folder. |
|
Should I copy them manually or is there a script to do it? |
|
Manually currently. There's a PR to use npm, but now just manually copy of the folder. |
|
Done. |
|
Thanks, great work again. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR implements Object.hasOwn
It is still a proposal (Github) but most major browsers implement it already.
I don't know what is your usual procedure for testing this kind of stuff, but I got the tests from V8 source code.