Fix iteration in interop #967
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Collaborator
lahma
commented
Sep 25, 2021
•
lahma
commented
- array-like when list or array should iterate values (like Set)
- dictionary-likes should iterate keys and values (like Map)
- IEnumerable behaves like custom Iterable added to regular JS object (enumerates values as-is)
- any other object type is unsupported like in normal JS (like basic objects { "A": 1 })
lahma
force-pushed
the
fix-interop-iteration-behavior
branch
from
5bb31d9
to
6b86b06
Compare
|
Not the easiest of changes. |
sebastienros
approved these changes
Sep 25, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.