Use UUID v4 for the ID property and remove the domain property
#215
Conversation
gprst
changed the title
domain property
|
Hi, out of curiosity, is there any preliminary thing I'd need to fulfil before this PR gets merged ? |
|
@gprst No, this PR is currently lying around until several breaking changes for a new major version have come together. I don't see this PR as so important that it should be merged immediately. So it's not for you to do, don't worry. |
# [1.3.0-develop.2](v1.3.0-develop.1...v1.3.0-develop.2) (2021-03-05) ### Features * **Events:** Use uuid-random for random UUIDs (close [#215](#215)) ([a4c19cc](a4c19cc))
|
🎉 This issue has been resolved in version 1.3.0-develop.2 🎉 The release is available on:
Your semantic-release bot 📦🚀 |
|
@sebbo2002 It appears you've just taken my commits and published them in your name. That's not nice |
|
@gprst Fortunately, it only looks like this at first glance. Unfortunately, the pull request could no longer be merged without major conflicts after the typescript refactoring, so I decided to go this route. Of course, I could have written to you again to update the PR, but honestly: I assumed that no one would feel offended, because in the end there was only one Of course, you are free to open a pull request and comment on the use of |
|
Okay, thank you for taking the time to explain me what lead this PR to be closed and the feature still be added. I should have taken the time to look at the differences between the code you wrote and mine. My appologies for the quick accusations. |
# [2.0.0](v1.15.4...v2.0.0) (2021-04-28) ### Bug Fixes * **package.json:** add temporary version ([0bc117e](0bc117e)) * Allow to set null values within object constructors ([8b87183](8b87183)) * **deps:** Also define libs as devDependency for tests ([c04ae32](c04ae32)) * **deps:** Define supported libs as peerDependencies ([84e2784](84e2784)) * Make peer dependencies optional ([b384ac7](b384ac7)), closes [#244](#244) * **Tools:** Prevent formatDate() from using global timezones prefixed with a slash ([85ab7b2](85ab7b2)) * **deps:** Put necessary typings in peerDependencies as well :/ ([14f0f43](14f0f43)) * **Event:** Remove `moment` dependency in constructor ([8331d4c](8331d4c)), closes [#234](#234) ### Code Refactoring * **Calendar:** Remove moment.Duration from `ttl()` method ([c6ccd12](c6ccd12)) * Update error URLs ([2aedf55](2aedf55)) ### Features * **Event:** Add `priority()` method ([247039f](247039f)), closes [#163](#163) * **Attendee:** Add `x()` method for custom attributes ([5d9d686](5d9d686)), closes [#183](#183) * **Calendar:** add new clear method ([1ebefcb](1ebefcb)), closes [#188](#188) * Add ReleaseBot ([2fba164](2fba164)) * **Calendar:** Add support for external VTimezone generator ([f4bc8e0](f4bc8e0)), closes [#122](#122) * **Event:** Allow `X-APPLE-STRUCTURED-LOCATION` without address ([4e63e29](4e63e29)), closes [#236](#236) * **Event:** Make organizer.email optional ([8450492](8450492)), closes [#137](#137) * **Event:** Merge `location()`, `appleLocation()` and `geo()` ([62c1516](62c1516)), closes [#187](#187) * Merge event's `description()` and `htmlDescription()` ([ce537f8](ce537f8)) * Support moment.js, Day.js and Luxon ([#91](#91), BREAKING CHANGE) ([6db24ee](6db24ee)) * **Event:** Support RRule objects and raw strings in `repeating()` ([4436785](4436785)), closes [#190](#190) * Updated the entire codebase to Typescript ([d013dc0](d013dc0)) * **Events:** Use uuid-random for random UUIDs (close [#215](#215)) ([a4c19cc](a4c19cc)) ### BREAKING CHANGES * Some error messages changed, so if you check for error , please double check them now. * `htmlDescription()` was removed, use `description()` instead. * **Calendar:** `ttl()` will now return a number, not a `moment.Duration`. You can still use `moment.Duration` to set the `ttl` value. * **Event:** `geo()` and `appleLocation()` are not available anymore, use `location()` instead and pass an location object (with title, radius, etc.) * **Calendar:** Calendar's `clear()` method is a completely new implementation and, unlike previous versions, will not reset metadata such as `name` or `prodId`. Only the events will be removed
|
🎉 This issue has been resolved in version 2.0.0 🎉 The release is available on: Your semantic-release bot 📦🚀 |
Resolves #203.
UUID v4 support: I chose uuid-random over more popular packages (such as uuid) because its unpacked size is much smaller, and it only implements the feature we need here — random (cryptographically secure) UUID v4 generation.
domainproperty removal: as this property isn't used anywhere anymore, it is completely wiped from the project.With this, the UID property of an event is now a UUID, rather than an ID with
@somedomainappended.