missing dayjs module in develop branch

[pintux]

I've installed version 2.0.0-develop.2 in a TypeScript project. At compile time, on my project, I'm getting:

node_modules/ical-generator/dist/types.d.ts:3:23 - error TS2307: Cannot find module 'dayjs' or its corresponding type declarations.

3 import { Dayjs } from 'dayjs';

Found 1 error.

[sebbo2002]

Could you try version 2.0.0-develop.4 again? Thank you.

[pintux]

Using 2.0.0-develop.8 version I'm getting the following errors, same happens with 2.0.0-develop.4:

node_modules/ical-generator/dist/event.d.ts:1:28 - error TS2307: Cannot find module 'rrule' or its corresponding type declarations.

1 import type { RRule } from 'rrule';
                             ~~~~~~~

node_modules/ical-generator/dist/types.d.ts:3:28 - error TS2307: Cannot find module 'dayjs' or its corresponding type declarations.

3 import type { Dayjs } from 'dayjs';
                             ~~~~~~~


Found 2 errors.

[sebbo2002]

Oh crap, how stupid of me. I'll take care of it tonight.

[sebbo2002]

Okay, thought I forgot to add the type flag for RRule, but that's not the issue. I tested it locally, it works for me. Do you use typescript >= 3.8? The type only imports are introduced in this version…

[pintux]

I'm using TypeScript 3.9.9 and (now) ical-generator version ^2.0.0-develop.14".

> tsc -v && tsc

Version 3.9.9
node_modules/ical-generator/dist/event.d.ts:1:28 - error TS2307: Cannot find module 'rrule' or its corresponding type declarations.

1 import type { RRule } from 'rrule';
                             ~~~~~~~

node_modules/ical-generator/dist/types.d.ts:3:28 - error TS2307: Cannot find module 'dayjs' or its corresponding type declarations.

3 import type { Dayjs } from 'dayjs';
                             ~~~~~~~


Found 2 errors.

I will try with a clean project

[sebbo2002]

Okay, I have now been able to reproduce the whole thing. Apparently, the dependencies must still be present when compiling in order to be able to check the types. Even if you use type-only imports. This is of course very annoying. I would put the dependencies in optionalDependencies, then they are usually installed automatically (if not already done). And since they will no longer be in the JavaScript, there should be no issue with this solution. I will do this in the next few days, but I don't have the time now.

[sebbo2002]

Okay, I have now packed the supported external libraries into peerDependencies. This way they should always be installed with npm 7. I hope this solves the problem. peerDependencies are installed with npm@7, before that you have to install them manually. I will add to the FAQ accordingly.