Add SystemTime
#9
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
iceiix
added a commit
to iceiix/stevenarella
that referenced
this pull request
Dec 27, 2020
Although there's an open pull request to the `instant` crate to support SystemTime and UNIX_EPOCH (sebcrozet/instant#9), it is simpler to change ui/logo to simply use Instant and Duration.
|
@sebcrozet I'd be interested in this PR. Would you be open to merging it if I warm it up? |
3 tasks
sebcrozet
requested changes
Oct 1, 2021
| pub struct SystemTime(f64); | ||
|
|
||
| impl SystemTime { | ||
| pub const UNIX_EPOCH: SystemTime = SystemTime(0.0); |
There was a problem hiding this comment.
I don’t think this is a valid definition. It is my understanding that doing SystemTime::now().duration_since(SystemTime::UNIX_EPOCH) should return the duration since the unix epoch. However, the now function may return results from the JS function performance.now(), which is not relative to the UNIX epoch.
There was a problem hiding this comment.
What about wngr@bd46ccb ? If @expenses agrees, I could create a new PR based on her commits.
|
Closing this because #42 was merged instead. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hi, It would be super useful to have a
SystemTimeimplementation, mostly forUNIX_EPOCH.