New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

throttled-reads-upper-threshold is documented as being a percentage; actually a count #169

Closed
willbuckner-work opened this Issue May 20, 2014 · 3 comments

Comments

Projects
None yet
2 participants
@willbuckner-work

willbuckner-work commented May 20, 2014

Documentation for throttled-reads-upper-threshold:

throttled-reads-upper-threshold int How many percent of the table capacity should be throttled before Dynamic DynamoDB scales up the read provisioning?

But, in the code, it's actually only looking at the throttled read event COUNT, not percentage, in the last 5 minutes (not even in the last check-interval) :( Either the code or the docs are wrong. Thanks!

@sebdah sebdah added this to the 1.14.x milestone May 20, 2014

@sebdah sebdah self-assigned this May 20, 2014

@sebdah

This comment has been minimized.

Owner

sebdah commented May 20, 2014

Thanks for highlighting this. The docs are wrong, I will update them.

sebdah added a commit that referenced this issue May 20, 2014

@sebdah sebdah closed this May 20, 2014

@willbuckner-work

This comment has been minimized.

willbuckner-work commented May 21, 2014

No problem, thanks for fixing. Also,since my check-interval is 1 minute, will it continue to raise the provisioning every minute during the 5 minute period where my throttle count remains over the threshold? I'd only want one increase during this 5 minute period unless the throttle count keeps raising significantly.

@sebdah

This comment has been minimized.

Owner

sebdah commented May 21, 2014

Add a note that it is counted per 5 min interval.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment