Scaling up by percent doesn't seem to calculate the amount Correctly #235

Closed
jlpassm opened this Issue Feb 17, 2015 · 5 comments

Projects

None yet

2 participants

@jlpassm
jlpassm commented Feb 17, 2015

I thought I understood the documentation, but Dynamic DynamoDB doesn't seem to work like I expected.

Dynamic DynamoDB recognizes that it should scale up and sends the notification. Then when it calculates the amount to scale up, it calculates what the current Read provisioning units are.

I expected once the event was recognized ( reads above 65%) that it would scale the reads up by 50%, which I expected to be 30*50% = 15 units, or scale up to 45 read units. If I change percent to units and 50 to 15 in the configuration file it does scale up by 15 units. I would prefer to use percent.

The read through put is currently set to 30 units and the log states that it will scale up to 30.0. This doesn't look correct to me. Here is the log:

image

The relevant section of my configuration file looks like this:

image

@sebdah sebdah added this to the 1.20.x milestone Feb 17, 2015
@sebdah sebdah self-assigned this Feb 17, 2015
@sebdah
Owner
sebdah commented Feb 17, 2015

Thanks, this is a bug and it looks like it is caused by a faulty float conversion. I'm looking at it.

@sebdah sebdah added a commit that referenced this issue Feb 17, 2015
@sebdah Fixed percent float conversion #235 b1a308f
@sebdah
Owner
sebdah commented Feb 17, 2015

I have pushed out a fix in 1.20.3, could you please test it on your environment?

@jlpassm
jlpassm commented Feb 17, 2015

I'll give it a shot.
What is the quickest easiest way to install the fix on my EC2 instance?

@jlpassm jlpassm closed this Feb 17, 2015
@sebdah
Owner
sebdah commented Feb 17, 2015

pip install -U dynamic-dynamodb

On Tue, Feb 17, 2015, 21:20 Jim Passmore notifications@github.com wrote:

Closed #235 #235.

Reply to this email directly or view it on GitHub
#235 (comment).

@jlpassm
jlpassm commented Feb 17, 2015

Looks like it works like I expected now. Nice work Sebastion.

Thanks!!!!!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment