Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Failure on non-matching regular expressions #69

Closed
TelegramSam opened this issue Oct 22, 2013 · 1 comment
Closed

Failure on non-matching regular expressions #69

TelegramSam opened this issue Oct 22, 2013 · 1 comment

Comments

@TelegramSam
Copy link

The lines:

            # Add regular tables
            for table_name in configured_tables:
                table_names.add((table_name, table_name))

on 61 and 115 of dynamic-dynamodb / dynamic_dynamodb / init.py

prevent the use of configurations for regular expressions that don't match anything, and don't actually serve any purpose.

Since a simple table name is a regular expression for itself, those are all added in the testing of regular expressions, so this code is never used, unless a configured table is missing.

This code should be removed.

@ghost ghost assigned sebdah Oct 24, 2013
sebdah added a commit that referenced this issue Oct 24, 2013
@sebdah
Copy link
Owner

sebdah commented Oct 24, 2013

Thanks for this observation @TelegramSam! I have updated the code in the development branch.

@sebdah sebdah closed this as completed Oct 24, 2013
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants