Failure on non-matching regular expressions #69

Closed
TelegramSam opened this Issue Oct 22, 2013 · 1 comment

Projects

None yet

2 participants

@TelegramSam

The lines:

            # Add regular tables
            for table_name in configured_tables:
                table_names.add((table_name, table_name))

on 61 and 115 of dynamic-dynamodb / dynamic_dynamodb / init.py

prevent the use of configurations for regular expressions that don't match anything, and don't actually serve any purpose.

Since a simple table name is a regular expression for itself, those are all added in the testing of regular expressions, so this code is never used, unless a configured table is missing.

This code should be removed.

@sebdah sebdah was assigned Oct 24, 2013
@sebdah sebdah added a commit that referenced this issue Oct 24, 2013
@sebdah Removed unused code. Closes #69 1a07204
@sebdah
Owner
sebdah commented Oct 24, 2013

Thanks for this observation @TelegramSam! I have updated the code in the development branch.

@sebdah sebdah closed this Oct 24, 2013
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment