New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Prevents scaling down write capacity as long as there are throttled w… #319

Merged
merged 1 commit into from Aug 10, 2017

Conversation

Projects
None yet
3 participants
@grom-it

grom-it commented Dec 29, 2016

…rite requests.

Please integrate this commit into the main project. It solves the following issue:

The dynamic DynamoDB scaler considers the used write capacity and the number of throttled writes when scaling up. This works fine.
But when scaling down it only considers the used write capacity - but ignores the throttled writes. This made the scaler scaling capacity up and down continuously when the used write capacity collapsed due to throttled writes.

So I added a little check that prevents it from scaling down as long as there are still throttled writes.

Cheers
Robert

@nigels-com

This comment has been minimized.

nigels-com commented Jun 6, 2017

Yes, that's a good criteria, agreed.

@sebdah sebdah changed the base branch from master to develop Aug 10, 2017

@sebdah sebdah merged commit dd84245 into sebdah:develop Aug 10, 2017

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment