Don't delete nested directories #42
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
*Problem* Take test cases stuctured in the following way TestSomeFunctionality - SubTestA - SubSubTestX - SubSubTestY - SubTestB When SubTestB is updated, it will delete the `TestSomeFunctionality/` directory. That means the next time we run SubTestA it will have no Goldie files. *Solution* Only delete the files in the current test folder, not the nested subdirectories. This preserves nested test sub-cases.
nestorowicz
reviewed
Aug 25, 2023
That's something I need to think about. My opinion is that cleaning should be done upfront, at the top level, before running any tests. Not sure if there's a mechanism for this currently though. |
|
Closed by #43 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Problem
Take test cases stuctured in the following way
TestSomeFunctionality
When SubTestB is updated, it will delete the
TestSomeFunctionality/directory. That means the next time we run SubTestA it will have no Goldie files.Solution
Only delete the files in the current test folder, not the nested subdirectories. This preserves nested test sub-cases.