Enable multiple value index for collection #18
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
pymongo supports ensure_index(key_or_list) where list can be [('key1',
direction,), ('key2', direction),]. This patch will allow scrapy-mongodb
to properly handle upserts when MONGODB_UNIQUE_KEY is a list of tuples
|
Thank you for the pull request @sherzberg. I will take a closer look on this tomorrow! |
sebdah
changed the title
|
Thanks again for the PR. It looks good and I have merged it and released it in version 0.7.2. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
pymongo supports ensure_index(key_or_list) where list can be [('key1',
direction,), ('key2', direction),]. This patch will allow scrapy-mongodb
to properly handle upserts when MONGODB_UNIQUE_KEY is a list of tuples