Transaction ExecPostHooks missing entityData

[aroraenterprise]

When doing a transaction and after calling execPostHooks on the transaction my post save functions do not have 'this' set to the current entity. Which means I am unable to work with the entity in my post save hooks for example when I am using transactions.

[sebelga]

Hello,
Could you share your Schema with the post hooks + a small example of your transaction so I can reproduce it?
thanks!

[aroraenterprise]

const eventSchema = new Schema({
  organizerId: { type: String, required: true },
  created: { type: Number, write: false },
  modified: { type: Number, write: false },
  version: { type: String, default: process.env.AppVersion, write: false },
  creatorId: { type: String, required: true, write: false },
  // additional props
 ...
}, { explicitOnly: true, keyType: 'id' });

async function setCreatorPermissions() {
  console.log('here i do some stuff with permissions...');
  return new Promise.resolve();
}

function indexEvent() {
  const entity = datastoreUtility.fromDatastore(this.entityData);
  return new Promise((resolve) => {
    algoliaClient.update(
      `${eventKind}-${entity.id}`,
      entity,
      () => {
        resolve();
      },
    );
  });
}

eventSchema.post('save', [
  setCreatorPermissions,
  indexEvent,
]);

module.exports = gstore.model(eventKind, eventSchema);

Transaction Example

const transaction = gstore.transaction();
  await transaction.run();

  try {
  const event = await Event.get(eventId);
    const itemData = Event.sanitize(cartData);
    const item = new Event(
      itemData
    );
    await item.save(transaction);
    await transaction.commit();
    await transaction.execPostHooks(); // this doesn't seem to execute the post save hooks...
    if (event[gstore.ERR_HOOKS]) {
      return {
        success: false,
        ...event[gstore.ERR_HOOKS][0],
      };
    }
    return {
      success: true,
      output: event.plain()
    };
  } catch (error) {
    return {
      success: false,
      error,
    };
  }

[sebelga]

Hi,
Thanks for reporting, the scope on the entity was missing indeed in the execPostHooks() call.
I just made a release with a fix (v4.2.4), let me know if it solves the issue.

A few comments on your code example:

const eventSchema = new Schema({
  organizerId: { type: String, required: true },
  created: { type: Number, write: false },
  modified: { type: Number, write: false },
  version: { type: String, default: process.env.AppVersion, write: false },
  creatorId: { type: String, required: true, write: false },
  // additional props
 ...
});

// You don't need to set { explicitOnly: true, keyType: 'id' }, it is the default

async function setCreatorPermissions() {
  console.log('here i do some stuff with permissions...');
  return new Promise.resolve(); // remove the "new"
}

...

const transaction = gstore.transaction();
await transaction.run();

try {
  const event = await Event.get(eventId); // why this line?
    const itemData = Event.sanitize(cartData);
    const item = new Event(
      itemData
    );
    const event = await item.save(transaction); // Set the "event" here not on the "get"
    await transaction.commit();
    await transaction.execPostHooks();
    
    if (event[gstore.ERR_HOOKS]) {
      return {
        success: false,
        ...event[gstore.ERR_HOOKS][0],
      };
    }
    ....
  }

[aroraenterprise]

Okay will try in a day or so and report back! Thank you for taking the time to read and comment over the code!

[sebelga]

Great, happy to help. Let me know how it goes!

[aroraenterprise]

It worked! Thank you so much.

[sebelga]

Great, thanks for the feedback! 👍