Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

sanitize() does not strip unknowns when using Joi schema validation #139

Closed
aroraenterprise opened this issue Dec 26, 2018 · 1 comment
Closed

sanitize() does not strip unknowns when using Joi schema validation #139

aroraenterprise opened this issue Dec 26, 2018 · 1 comment

Comments

@aroraenterprise
Copy link

Hey, I am sure I am probably doing something wrong but when I use the Joi schema to do validation, keys that are not in my schema but present in my data are not stripped in sanitize or during save. This means that basically anything present in the data is stored into the database. When i wasn't using joi for validation, sanitize/save would strip out these keys automatically. Love your help.
sebelga added a commit that referenced this issue Dec 29, 2018
@sebelga
fix(Sanitize): Remove non writable property on Joi schema
3e764dd 
#139
@sebelga sebelga mentioned this issue Dec 29, 2018
Merged
sebelga added a commit that referenced this issue Dec 29, 2018
@sebelga
fix(Sanitize): Remove non writable property on Joi schema (#140)
4ba1ce6 
#139
@sebelga
Copy link
Owner

sebelga commented Dec 29, 2018

Hi,
Thanks for reporting this, it was indeed a regression from a fix I added lately.
I just release v4.3.3 that should fix this issue. Let me know if it's working on your side.
Cheers!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@sebelga @aroraenterprise