Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Incompatibility with @google-cloud/datastore 0.5.0 #19

Closed
5un opened this issue Oct 21, 2016 · 3 comments
Closed

Incompatibility with @google-cloud/datastore 0.5.0 #19

5un opened this issue Oct 21, 2016 · 3 comments

Comments

@5un
Copy link

5un commented Oct 21, 2016

As google-cloud datastore lib has changed their entity response format from
{ key: someKey, data: someData }
to
{ entityData }
in @google-cloud/datastore 0.5.0 (The change is actually in this commit ), this clearly will breaks model creation. For example, trying to fetch an entity with a key would result in the following error as entity.key in the response is no longer presence.

/MyProject/node_modules/gstore-node/lib/serializers/datastore.js:23

 data.id  = entity.key.path[entity.key.path.length - 1];

                      ^

TypeError: Cannot read property 'path' of undefined

May I ask whether there is any plan to support datastore 0.5.0 soon?

@sebelga
Copy link
Owner

sebelga commented Oct 21, 2016

Hi, thanks for reporting. Yes there is plan to support it, hopefully by the end of the week.

Next thing on the list are to add Promises and follow their very nice support of it :)

@sebelga
Copy link
Owner

sebelga commented Oct 22, 2016

Hi, I just updated the library (v0.7.0) to support datastore 0.5.0. Could you upgrade and test if it works on your side. Thank you!

@5un
Copy link
Author

5un commented Oct 25, 2016

0.7.0 seems to work well so far. Thanks man. Appreciated your work and the swift update on this repo!

@5un 5un closed this as completed Oct 25, 2016
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants