Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

modifiedOn not automatically updating when using gstore.save #202

Closed
eungkyu opened this issue Nov 2, 2019 · 2 comments · Fixed by #209
Closed

modifiedOn not automatically updating when using gstore.save #202

eungkyu opened this issue Nov 2, 2019 · 2 comments · Fixed by #209

Comments

@eungkyu
Copy link

eungkyu commented Nov 2, 2019

modifiedOn is automatically updating when using entity.save, but not by using gstore.save
@sebelga
Copy link
Owner

sebelga commented Nov 6, 2019

Hi,

Thanks for reporting. Indeed it was not implemented in gstore.save(). I will add it. 👍

sebelga added a commit that referenced this issue Dec 8, 2019
@sebelga
fix(gstore.save()): update "modifiedOn" property on entities
5e37579 
When entities have a "modifiedOn" property declared on their schema, saving the entity (with
entity.save() or gstore.save()) will update update the property with the current time.

fix #202
@sebelga sebelga mentioned this issue Dec 8, 2019
Merged
sebelga added a commit that referenced this issue Dec 8, 2019
@sebelga
fix(gstore.save()): update "modifiedOn" property on entities (#209)
94b74d8 
When entities have a "modifiedOn" property declared on their schema, saving the entity (with
entity.save() or gstore.save()) will update update the property with the current time.

fix #202
@sebelga
Copy link
Owner

sebelga commented Dec 8, 2019

I just added a fix to update the modifiedOn with gstore.save(). It will be available in the next release. Cheers 👍

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

fix(gstore.save()): update "modifiedOn" property on entities sebelga/gstore-node
2 participants
@eungkyu @sebelga