Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Sorting of versions is wrong #37

Closed
seltzdesign opened this issue Jul 20, 2022 · 3 comments
Closed

Sorting of versions is wrong #37

seltzdesign opened this issue Jul 20, 2022 · 3 comments

Comments

@seltzdesign
Copy link

The sorting of the dropdown of versions is wrong. It is not interpreting the numbers correctly, but doing a pure alphabetical sort. "2021.4.10-138" should come between "2022.5.0-0040" and "2021.4.9-975". But now it is between "2022.4.2" and "2022.4.1".

Thanks for fixing, GammaLauncher rules.

image

@seltzdesign
Copy link
Author

I just noticed another issue, which you can see in the same screenshot: The dropdown with the versions actually gets cut off. It either needs to be scrollable or extend outside of the frame of the application. Thanks!

@sebescudie
Copy link
Owner

Wow, for whatever reason I'm only seeing this issue now, sorry for the delay! Yes, that looks fishy indeed. I'm relying on some .NET library to parse semver, and it indeed seems to have issues sorting those. Thanks for the report, cannot promise when but I'll try to have a look these days.

Regarding your second issue, there's no scrollable dropdown in Elementa and I don't see one being added in the near feature. Not ideal but you can already scroll while hovering the (closed) dropdown to scroll through versions.
This issue will most likely be solved when rewriting the launcher using ImGUI, see #40

sebescudie added a commit that referenced this issue Oct 7, 2022
…ebetically. LocalVVVV's Label property is now Version. Adds to #37
@sebescudie
Copy link
Owner

sebescudie commented Oct 10, 2022

@seltzdesign The sorting issue will be fixed in next release, thanks again for the report.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants