Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Accordion #38

Closed
5 tasks done
ulde01 opened this issue Mar 11, 2019 · 4 comments
Closed
5 tasks done

Accordion #38

ulde01 opened this issue Mar 11, 2019 · 4 comments
Labels
developing Component is being developed reviewed/answered DMT reviewed or answered

Comments

@ulde01
Copy link
Contributor

ulde01 commented Mar 11, 2019

Design review March 27

The accordion has been updated.

Change

  • The green “tab border” is removed
  • Font in header is 20 px. Subheader is optional: 14 px
  • Header cell height: 48 px. If there is also a subheader: 64 px
  • Grey hover is added on the header cell
  • Content background is still white/none, with the option to make it grey
  • Chevron (FontAwesome Light) points up/down (not right/down)
  • Guidelines now include: "Use this component mainly for text content"

Reason
Many reasons. First of all, it was time to specify the component better. We have adjusted to fit users’ need with more efficient use of space. The direction of chevron is updated to show how it is animated. We also noticed that the component has been (too) content-heavy and added clearer guidelines.

Specification
https://designlibrary.sebgroup.com/components/accordion/

image

Added to frameworks

Let us know if you have any questions!
/Ulrika
Design management

@ulde01 ulde01 added the discussion Open for discussion label Mar 11, 2019
@ulde01 ulde01 changed the title Accordions Accordion Mar 11, 2019
@ulde01 ulde01 added this to Discussion (active) in Design discussions Mar 11, 2019
@SofiaDubbelve
Copy link

can the new accordion have a nice slide up/down animination? :)

@henrikhoglundseb
Copy link

definitely! Thats one off the things we will add :)

@mario-subo
Copy link

I don't think we should limit the amount of content an accordion can hold (in its body at least). It should accept a string of any length and display it as text and possibly even a custom component, meaning whatever you pass in the body will be displayed. This would make the accordion very powerful. This is something, the front x team discussed, the dialog/modal component should be able to do as well.

Also agree it should animate.

We should also discuss if the logic for the expanded state of the accordion (expanded: true | false) is contained within the component itself or should the parent component manage that (). I would suggest both. An internally managed logic unless the expanded flag is explicitly passed down to the component.

@ulde01
Copy link
Contributor Author

ulde01 commented May 2, 2019

Hej @mario-subo , thanks for the input! Good to see you here. We have discussed this at length as well, and user-tested the component. When content = headers, text, inline links, then the component can contain more. But we have seen videos and other huge content which works less well.

@ulde01 ulde01 moved this from Discussion (active) to Under development in Design discussions May 6, 2019
@ulde01 ulde01 added developing Component is being developed reviewed/answered DMT reviewed or answered and removed designing discussion Open for discussion labels May 20, 2019
@ulde01 ulde01 closed this as completed Aug 20, 2019
@ulde01 ulde01 reopened this Aug 20, 2019
@ulde01 ulde01 closed this as completed Oct 9, 2020
@ulde01 ulde01 moved this from Under development to Done in Design discussions Oct 9, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
developing Component is being developed reviewed/answered DMT reviewed or answered
Projects
None yet
Development

No branches or pull requests

4 participants