Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Dropdown multiselect #59

Open
3 of 5 tasks
TheresaHedlund opened this issue Apr 10, 2019 · 10 comments
Open
3 of 5 tasks

Dropdown multiselect #59

TheresaHedlund opened this issue Apr 10, 2019 · 10 comments
Labels
developing Component is being developed

Comments

@TheresaHedlund
Copy link

TheresaHedlund commented Apr 10, 2019

Decision from the Design review May 8

The dropdown now has another version that allows multiple selections.

image

Full specification
See states and sizes here: https://designlibrary.sebgroup.com/components/forms/dropdown/#styles

Component identifier
component-dropdown

Thank you! :)
Ulrika
Design management

@TheresaHedlund
Copy link
Author

TheresaHedlund commented Apr 23, 2019

How complicated does it have to be? What's your need?

  • select/deselect all option?
  • need of a search within the options list?
  • how to show what's selected

Some examples so you can see what I'm trying to say :)
image

Created a first suggestion: https://share.goabstract.com/e8f20342-c78b-4e55-aae7-0467ca012182

@ghost
Copy link

ghost commented Apr 27, 2019

Think it looks good @TheresaHedlund 😍
Maybe we can add this multiselect as symbols for now and when we find further needs of functionality we dig in to it when that time comes?

@ulde01
Copy link
Contributor

ulde01 commented Apr 29, 2019

I like too, very clean and nice! If anyone has input, please share asap.

Next step is to (if you haven't already)

  • Add this to the masterfile in Sketch,
  • Send it out for review through Abstract
  • Review it on the next Working group meeting
  • Add issues in Github to be developed
  • Show at Henkes komponent

Did/will your team develop this and add the code to design library @TheresaHedlund ?

@hjalmers
Copy link
Contributor

hjalmers commented Apr 29, 2019

I think we need a version with an option to use an input field as well to filter the items in the dropdown, something like this: https://github.pytes.net/tail.select/ (just the first hit on google) and like your third example here #59 (comment).

@TheresaHedlund
Copy link
Author

I like too, very clean and nice! If anyone has input, please share asap.

Next step is to (if you haven't already)

  • Add this to the masterfile in Sketch,
  • Send it out for review through Abstract
  • Review it on the next Working group meeting
  • Add issues in Github to be developed
  • Show at Henkes komponent

Did/will your team develop this and add the code to design library @TheresaHedlund ?

The development of this will probably not happen until after summer, or even later, due to change of plans in project.

@TheresaHedlund
Copy link
Author

I think we need a version with an option to use an input field as well to filter the items in the dropdown, something like this: https://github.pytes.net/tail.select/ (just the first hit on google) and like your third example here #59 (comment).

Do you think any of these would work better or maybe not at all? :)
image
And, could we choose to use "Select all" and "Search" only if needed?

@hjalmers
Copy link
Contributor

I would vote for v3 and perhaps search should be filter or find as the user would filter the options below based on the input in the field but that's up for discussion and user testing:)

v1 and v2 might look cleaner but it might be confusing if the items/options below are removed based on the input i.e. if user types Option 3 then Option 1 and Option 2 would be removed but Select all wouldn't? v3 makes that distinction clearer in my opinion as only the options below the input would be altered:)

Select all and Search should be optional, same as the ability to select multiple values. I've actually created an issue for it here: sebgroup/ng-components#22 (currently requires special permission as it's not public yet).

@ghost
Copy link

ghost commented Apr 30, 2019

I vote for v1 with a little twist. The "Select all" should be visible even after you get suggestions on your selection. So it might need a line to. (But only if there still are a few options left.)
Agree on the Filter or Find instead of Search.

@didzisspruds
Copy link

I would agree to Jesssi. I vote for version1 as it looks more simple to me.

@ulde01 ulde01 changed the title Need of a multiselect / dropdown with multiple selects? Dropdown multiselect May 9, 2019
@TheresaHedlund
Copy link
Author

TheresaHedlund commented May 13, 2019

New iteration for version 1. We decided to keep the word "Search", since that seems like the most common one used in other examples.

ver1

@ulde01 ulde01 added developing Component is being developed and removed designing discussion Open for discussion labels May 20, 2019
@ulde01 ulde01 moved this from Discussion (active) to Under development in Design discussions May 20, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
developing Component is being developed
Projects
Development

No branches or pull requests

4 participants