Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Tooltip misaligned and not able to close in mobile #89

Closed
yousifalraheem opened this issue Nov 13, 2019 · 2 comments
Closed

Tooltip misaligned and not able to close in mobile #89

yousifalraheem opened this issue Nov 13, 2019 · 2 comments
Assignees
@kherP
Labels
🐛 Bug Something isn't working 🚀 Release
Milestone
April Release

Comments

@yousifalraheem
Copy link
Contributor

Describe the bug
When triggering a tooltip on mobile, tooltip message box is misaligned and not able to be closed.

To Reproduce
Steps to reproduce the behavior:

  1. Go to 'Dashboard' using mobile
  2. Click on the info icon
  3. See the misalignment and the tooltip cannot be closed.

Expected behavior
Tooltip message should be able to view clearly and toggle to be hidden or to be seen

Screenshots
801d2180-f030-11e9-9d7e-3577b573ac47
@yousifalraheem yousifalraheem added the 🐛 Bug Something isn't working label Nov 13, 2019
@EldRoos
Copy link

EldRoos commented Nov 13, 2019

We had this problem in our project too. Old iOS/Safari/Chrome do not trigger click on non button/inputs (newest version have fixed this). We also used "touchstart" to fix this.

kherP pushed a commit that referenced this issue Dec 12, 2019
fix(tooltip): fix tooltip bug
74a521d 
autoplacement is introduced, more trigger methods are introduced, allow user to pass custom content
as tooltip content, allow user to pass custom content as tooltip reference

BREAKING CHANGE: - customSvg, message, messageGroup, onClick, title, triggerOnHover, width are
removed. New attributes such as content, trigger, disableAutoPosition, onVisibleChange, children are
introduced.

fix #89
@kherP kherP mentioned this issue Dec 12, 2019
Closed
kherP pushed a commit that referenced this issue Dec 16, 2019
refactor(tooltip): refactor tooltip component
e8cdffa 
introduce new attributes to tooltip component and add in auto position when the tooltip overflow

#89
@yousifalraheem yousifalraheem added this to the February Release milestone Jan 29, 2020
@kherP kherP closed this as completed in 5445516 Feb 28, 2020
@sebopensource
Copy link

🎉 This issue has been resolved in version 3.0.0 🎉

The release is available on:

Your semantic-release bot 📦🚀

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@kherP kherP

Labels
🐛 Bug Something isn't working 🚀 Release
Projects
None yet
Milestone
April Release
Development

Successfully merging a pull request may close this issue.

fix(tooltip): fix tooltip bug seb-oss/react-components
4 participants
@yousifalraheem @kherP @EldRoos @sebopensource