update to angular 10 and @types/googlemaps

[ghost]

a major change, updates to angular 9 and 10, switch to angular cli building, and switch to @types/googlemaps typings

[codecov]

Codecov Report

Merging #1833 into master will increase coverage by 1.45%.
The diff coverage is 48.37%.

@@            Coverage Diff             @@
##           master    #1833      +/-   ##
==========================================
+ Coverage   47.97%   49.43%   +1.45%     
==========================================
  Files          47       28      -19     
  Lines        2001     1325     -676     
  Branches      178      124      -54     
==========================================
- Hits          960      655     -305     
+ Misses       1037      668     -369     
+ Partials        4        2       -2     

Impacted Files	Coverage Δ
packages/core/src/lib/directives/info-window.ts	27.90% <0.00%> (ø)
...re/src/lib/services/managers/data-layer-manager.ts	10.52% <0.00%> (ø)
...e/src/lib/services/managers/info-window-manager.ts	15.15% <0.00%> (ø)
...ore/src/lib/services/managers/kml-layer-manager.ts	25.00% <0.00%> (ø)
...rc/lib/services/maps-api-loader/maps-api-loader.ts	100.00% <ø> (ø)
packages/core/src/lib/utils/browser-globals.ts	60.00% <ø> (ø)
...s/core/src/lib/services/google-maps-api-wrapper.ts	4.76% <4.76%> (ø)
...terer/src/lib/services/managers/cluster-manager.ts	31.94% <27.27%> (ø)
.../core/src/lib/services/managers/polygon-manager.ts	71.73% <37.50%> (ø)
packages/core/src/lib/directives/marker.ts	30.55% <44.44%> (ø)
... and 45 more

---

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update ea471aa...f52b9f9. Read the comment docs.

[loicgasser]

Wow, thank you for this huge effort.

[Sampath-Lokuge]

Yes, this is great news. We hope you'll release this soon. Thank you!

[iget-esoares]

Hope someone merge this soon

[TxusBlack]

Thank you! We are exciting to use this update!

[ghost]

converted to draft because need to fix "Guides" page

[sp90]

I don't have extensive knowledge about the project but I can give it a review, especially because I would love for this to go out :D

[ghost]

thanks @sp90 , but we need a review from @SebastianM

[sp90]

@SebastianM we are awaiting your holyness 👍 🥇

[sp90]

I have found a few questionable changes, otherwise, it seemed pretty flawless. Could also be missing domain knowledge, but for what its worth here is a review 🚀

[explooosion]

It looks great!

Does it need to add @type/googlemaps to peerDependencies or dependencies in packages/core/package.json?

[ghost]

@explooosion @types/googlemaps is already in devDependencies for each of the packages.

@SebastianM please confirm that you were able to get it to build on your local, possibly with a newer yarn version. It doesn't only build successfully on my machine, it also works on netlify and travis

There does need to be an overall effort to sort all dependencies in their right places.

[shadow1349]

@doom777 thanks for these updates! I'm super excited to update my project.

[sebholstein]

@doom777 All packages are now published 🎉 . I got it published in an hour or so. The issue was the @types/googlemaps packages. In build:prod mode, I assume that the package gets ignored, so the typescript compiler throws some errors for the types. In non-prod mode, the build went fine.

I got it working by manually install the package before building in prod mode:

 npm i --no-save @types/googlemaps@^3.39.8

After this, I could build/publish the core but the next problem was that I couldn't build the other packages. I had to install @agm/core@3.0.0-beta.0 in all other packages before building.

Maybe you can rm -rf all your node_modules, run npm install again in all packages and then run npm build:prod to see if you can reproduce it.

[ghost]

@SebastianM I am still worried over building. It's NOT supposed to be built with npm, it's supposed to be installed and built with yarn. Then, you don't have any missing dependencies.

I just tested the following in a clean directory

git clone git@github.com:SebastianM/angular-google-maps.git
cd angular-google-maps
yarn
yarn build 

it worked without a hitch, without a need to install additional types or libraries or copy folders into node_modules. Same for yarn build:prod Please confirm you can do the same.

[khayargoli]

Angular CLI: 10.0.3
Node: 12.13.1
OS: win32 x64

Angular: 10.0.4
... animations, common, compiler, compiler-cli, core, forms     
... language-service, platform-browser, platform-browser-dynamic
... router
Ivy Workspace: <error>

Package                           Version
-----------------------------------------------------------     
@angular-devkit/architect         0.1000.3
@angular-devkit/build-angular     0.1000.3
@angular-devkit/build-optimizer   0.1000.3
@angular-devkit/build-webpack     0.1000.3
@angular-devkit/core              10.0.3
@angular-devkit/schematics        10.0.3
@angular/cdk                      10.0.2
@angular/cli                      10.0.3
@angular/material                 10.0.2
@ngtools/webpack                  10.0.3
@schematics/angular               10.0.3
@schematics/update                0.1000.3
rxjs                              6.6.0
typescript                        3.9.7
webpack                           4.43.0

USING: "@agm/core": "^3.0.0-beta.0",

Hi guys, Got this error recently. Any fix?

[explooosion]

Maybe @type/googlemaps should add to dependencies rather than devDependencies.

@Biswas123 npm install @types/googlemaps ?

[khayargoli]

Maybe @type/googlemaps should add to dependencies rather than devDependencies.

@Biswas123 npm install @types/googlemaps ?

Oh man! thanks! worked.

[ghost]

@explooosion maybe

[michaelz]

npm ERR! notarget No matching version found for @agm/js-marker-clusterer@^3.0.0-beta.0.

Is there something I need to be aware of ?

[ghost]

@michaelz yea, it was renamed to @agm/markerclusterer