Fix drawer transition styles #1352
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Problem
Because of a recent change with the transition module, drawers can no longer depend on the transition event to fire off the dialog element. This was relied on for the drawer component in its inline state to open and close.
Solution
This PR fixes the transition bug by moving the inline transition styles to the base
.drawerelement instead of the.drawer__dialog. The drawer modal transition also needed to be updated since it relied on the previous styles. Lastly, the drawer manifest import order was updated to help reduce selector weight between interdependent modifiers (.drawer_switchand.drawer_modal).Fixes #1351