Improve UX of docs drawer menu #194
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
sebnitu
force-pushed
the
imp-docs-drawer-menu
branch
from
4de794d
to
4b77851
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Problem
The drawer menu can be improved on in terms of both design and UX when you scroll to a component and navigate to it's page but the menu scroll jumps back to the top.
Solution
This PR introduces a
StickyScrollmodule that tracks the scroll position of an element and retains it's position when navigating to a different page. The script also checks that the active menu item is visible and adjusts the scroll position if it's not. Also introduced in this work is an updated drawer menu style to look more like tabs.