Merge tooltip into the popover component as a modifier #788
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
sebnitu
force-pushed
the
refactor-tooltip
branch
from
7148dc3
to
0bd3378
Compare
sebnitu
force-pushed
the
refactor-tooltip
branch
from
e71024f
to
a6979d1
Compare
…p event and placement values
sebnitu
force-pushed
the
refactor-tooltip
branch
from
a6979d1
to
63bc764
Compare
sebnitu
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What changed?
This PR includes a complete refactor the tooltips. It has been removed as a stand-alone component in favor of a popover modifier
popover_tooltip. This allows for shared styles and behavior to exist between the two implementations.