Use custom properties for sharing values between CSS and JavaScript #815
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
sebnitu
force-pushed
the
custom-properties
branch
from
a32c101
to
20bdcb7
Compare
sebnitu
force-pushed
the
custom-properties
branch
from
20bdcb7
to
1fafe56
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What changed?
This PR introduces global CSS variables. These allow for Vrembem to now set CSS variables in the core module which make them accessible in JavaScript modules.
This first implementation includes setting breakpoint custom properties that are then used in the Drawer component to handle breakpoints switching between modal and drawer modes.
CSS variables can optionally be output with a prefix using the core
$prefix-variablesass variable which defaults tonull. If set with a value (such as"vb-"), all CSS variables will be prefixed with"vb-"and a new CSS variable will be output:This is used in JavaScript modules that utilize CSS variables so they know how to look up a value using the correct property name.
This PR fixes #282