Refactor JS modules #832
Merged
Refactor JS modules #832
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
sebnitu
force-pushed
the
refactor-js-modules
branch
2 times, most recently
from
fbed8c8
to
531eecf
Compare
sebnitu
force-pushed
the
refactor-js-modules
branch
from
531eecf
to
2b17357
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What changed?
The PR introduces some general JavaScript modules refactoring. There are no functionality changes. Some of this refactoring includes:
call()when needing to pass a function thethiscontext.show/hidetoopen/closeto keep popover consistent with modals and drawers