New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Further refactor Popover JS module and improve a11y #838
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
sebnitu
force-pushed
the
js-module-a11y
branch
2 times, most recently
from
February 23, 2022 06:32
83dd770
to
c08622f
Compare
sebnitu
force-pushed
the
js-module-a11y
branch
from
February 25, 2022 01:58
1d4e29a
to
d0a42a7
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What changed?
This PR refactors some of the core architecture of the popover JS module and adds some handy new features along with some accessibility enhancements. Popovers now require
aria-controls="unique-id"
andid="unique-id"
attributes for triggers and targets respectively. This removes the need to add additional data attributes for popovers and their triggers.Another big addition in this PR is the
Collection
class whichPopover
extends. This allows for a re-usable pattern to build and interface with collections. Lays the groundwork in collections for modal and drawer modules (#835).Other changes include:
open()
andclose()
methods now take popover IDs.register()
andderegister()
methods now take popover ID or either popover elements.closeAll()
in favor of callingclose()
without a parameter to close all popovers.open()
,close()
andderegister()
.get()
method for retrieving collection entries by any popover object property (defaults toid
).Todos
This PR fixes #834