Update custom property output methodology #883
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Problem
With the introduction of custom properties (CSS variables), there hasn't been established a consistent way of including global custom properties that doesn't lead to output duplication.
Solution
This PR refactors how custom properties are organized and output. Instead of outputting them in the core module, the core module instead exposes root
scss
andcss
output files for manual inclusion. The global vrembem package now also includes all root custom properties by default.SCSS Example
CDN Example
With this update and in preparation for future custom properties, this PR also updates the custom property prefix default to
"vb-"
. That means all vrembem CSS variables should be prefixed withvb-
, e.g:--vb-breakpoint-md: 760px;
.This PR fixes #854