Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix conflicting bookings login filter #40

Open
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

aileo
Copy link
Contributor

@aileo aileo commented Feb 23, 2024

Hi,

I found out that when selecting a time range overlapping user's existing booking and someone else's booking on a seat, the delete action deletes both bookings.

I think the cause is in WarpSeatFactory.getMyConflictingBookings :

!i.book.login == this.login casts i.book.login as boolean first then compare its opposite value to this.login.

i.book.login != this.login checks if values are different.

Another way to do it could be !(i.book.login == this.login)

@Anbcorp
Copy link

Anbcorp commented May 16, 2024

Hello,

I tested this fix locally with docker-compose and it seems to fix the issue.

Thanks,

@sebo-b
Copy link
Owner

sebo-b commented Jun 14, 2024

Hi @aileo

I'm looking for a maintainer for this project, as I've not been able to spend much time on it recently. It seems that you have contributed a lot so far, so please let me know if you are interested.

Regards,
/S

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants