Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

#145 Cite-proc ignores et-al attributes if they set on bibliography/citation level. #148

Merged

Conversation

xopoc14
Copy link

@xopoc14 xopoc14 commented Feb 1, 2023

No description provided.

@seboettg
Copy link
Owner

seboettg commented Feb 5, 2023

Hi @xopoc14!
Thank you for your contribution! For some reason citeproc is rendering instead of & (ampersand) for various tests. Do you have any idea what could be the reason for this?

@xopoc14
Copy link
Author

xopoc14 commented Feb 7, 2023

@seboettg I am working on fixing for the broken tests.

@xopoc14 xopoc14 force-pushed the 145-citeproc-ignores-et-al-attributes branch from 2850670 to 3910bb7 Compare February 7, 2023 21:41
@xopoc14
Copy link
Author

xopoc14 commented Feb 7, 2023

@sebboettg I fixed broken tests and added a test for this bug.

Copy link
Owner

@seboettg seboettg left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great job!

src/Rendering/Name/Name.php Outdated Show resolved Hide resolved
@seboettg seboettg merged commit bd92689 into seboettg:develop Feb 8, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants