Skip to content
This repository has been archived by the owner on Apr 23, 2024. It is now read-only.

Failed TC with Grocy 3.3.0 #229

Closed
andreheuer opened this issue Apr 13, 2022 · 2 comments · Fixed by #230
Closed

Failed TC with Grocy 3.3.0 #229

andreheuer opened this issue Apr 13, 2022 · 2 comments · Fixed by #230

Comments

@andreheuer
Copy link
Contributor

andreheuer commented Apr 13, 2022

I have changed the test configuration to the demo instance of Grocy by modifying the test_const.py file and run the pytests against it.
However, the result of the test was not really successful:

test/test_battery.py .F.                                                                                                                                                                 [  3%]
test/test_chores.py FF...                                                                                                                                                                [  8%]
test/test_generic.py F......                                                                                                                                                             [ 15%]
test/test_grocy.py ..................................                                                                                                                                    [ 50%]
test/test_grocy_api_client.py ....                                                                                                                                                       [ 54%]
test/test_meal_plan.py FF.F                                                                                                                                                              [ 58%]
test/test_meal_plan_sections.py F..                                                                                                                                                      [ 61%]
test/test_misc.py .                                                                                                                                                                      [ 62%]
test/test_product.py FFF..F.                                                                                                                                                             [ 70%]
test/test_product_groups.py F                                                                                                                                                            [ 71%]
test/test_shoppinglist.py F......                                                                                                                                                        [ 78%]
test/test_stock.py F.F..                                                                                                                                                                 [ 83%]
test/test_system.py F                                                                                                                                                                    [ 84%]
test/test_tasks.py F...                                                                                                                                                                  [ 88%]
test/test_users.py .F                                                                                                                                                                    [ 90%]
test/test_utils.py .........                                                                                                                                                             [100%]

=========================================================================================== FAILURES ===========================================================================================

Maybe the tests should be updated to deal with the most recent demo instance of Grocy? This might also uncover missing feature implementations.

@andreheuer
Copy link
Contributor Author

@SebRut what would you recommend on how to proceed?

@SebRut
Copy link
Owner

SebRut commented Apr 16, 2022

In general, one would delete all files in tests/casettes and re-run the tests to re-record responses. After that, all failing tests have to checked (and changed if needed) for actual errors or simply assertions not matching responses anymore.

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants